Line graph on press fix#129
Merged
Merged
Conversation
added 2 commits
June 30, 2019 12:00
if sdkVersion is not present, expo will use the latest version installed on the computer vs the one from package.json
* change larger click circle to not rely on the fill to have opacity * remove Circles from View that were making them not show up in iOS
Contributor
|
Thank you for your contribution 👍 |
Contributor
Author
|
awesome, glad I could help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic for the LineGraph component relies on the passed in dataSet color to use the opacity param in the function. If you want a solid color, and don't use the opacity param, this creates a huge dot on the screen. So I updated the larger click area dot, to not rely on the opacity of the passed in color, but set it on the circle itself.
I also noticed that pulling down the code and running it, the dots were not showing up on the line graph in iOS. I noticed this when I upgraded to the latest version in my project as well. iOS seems to not like the dots being inside a View, and removing them from that, seemed to work.
Last thing I updated was updating the app.json for development. If you don't have sdkVersion set, it uses the latest version installed (currently sdk 33 for me) instead of the one from package.json. This was throwing errors for me.